Repository navigation
Add test IDs to the transcode failure surfaces - #2393
Merged
Merged
Conversation
- The failure reason, the next step and its links get a data-test-id, both when the page prints them and when polling redraws them. - link() takes an optional test ID. - The reason's test ID goes away once the file stops failing.
- setFailureText() marks the status icon with a data-test-id while it carries a failure reason, and removes it with the reason. - Unit tests for setFailureText().
- The panel and its title, reason, next step, Upgrade/next-step link, Retranscode button, Contact support link, status line and support details each get a data-test-id under godam-transcode-failure-panel. - el() takes an optional test ID.
🔍 WordPress Plugin Check Report
📊 Report
|
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
mismatched_plugin_name | Plugin name "GoDAM - Video Hosting for LMS & Online Courses" is different from the name declared in plugin header "GoDAM". |
0 |
readme_parser_warnings_trimmed_section_description | The "Description" section is too long and was truncated. A maximum of 2500 characters is supported. |
📁 inc/classes/class-media-library-ajax.php (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
1643 |
WordPress.NamingConventions.PrefixAllGlobals.NonPrefixedHooknameFound | Hook names invoked by a theme/plugin should start with the theme/plugin prefix. Found: "max_srcset_image_width". |
📁 assets/build/pages/video-editor.min.js (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
2 |
react_removed_api | This file calls "ReactDOM.findDOMNode", which was removed in React 19 and stops working once WordPress upgrades React. Use a ref on the element instead. |
📁 assets/build/css/main.css (1 warning)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedStylesScope | This style is being loaded in all contexts. |
📁 assets/src/libs/analytics.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/11/19/hello-world/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle analytics-library) is loaded in the footer. Consider a defer or async script loading strategy instead. |
📁 assets/build/js/main.min.js (5 warnings)
| 📍 Line | 🔖 Check | 💬 Message |
|---|---|---|
0 |
EnqueuedScriptsScope | This script is being loaded in all frontend contexts. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880 (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/2026/11/19/hello-world/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/sample-page/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
0 |
NonBlockingScripts.NoStrategy | This script on http://localhost:8880/demo-attachment-post/ (with handle rtgodam-script) is loaded in the footer. Consider a defer or async script loading strategy instead. |
🤖 Generated by WordPress Plugin Check Action • Learn more about Plugin Check
KMchaudhary
approved these changes
Nov 19, 2026
It goes straight into the 2.11.0 release, after the version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
A small 2.11.0 QA fix, for release ticket rtCamp/godam-plugin-wp#112, from QA's pre-release review (item 1):
Test IDs on the transcode failure surfaces. #2366 added three places that say why a transcode failed (the media list view, the grid view's tooltip and the attachment details panel) without any
data-test-id, so the E2E tests had nothing stable to select. Each now carries one, following the existingdata-test-id="godam-…"convention. One commit per surface.Where to look
List view: page render and polling redraw (
admin/godam-transcoder-functions.php:491-546,list-view-transcoding-status.js:115, 207,failure.js:67)The PHP render and
renderNextStep()give the same IDs:godam-transcode-failure-reason,godam-transcode-next-step,godam-transcode-next-step-link,godam-transcode-support-link.Check: the reason's ID is removed when polling moves the file out of failed, so a recovered file has none.
Grid view tooltip (
failure.js:113, 121)Check:
setFailureText( loader, '' )removes it along with the reason.Attachment details panel (
transcoding-refusal-panel.js:18-37)The panel, plus
-title,-reason,-next-step,-next-step-link,-retranscode,-support-link,-statusand-details.Everything else is mechanical:
link()(failure.js:32) andel()(transcoding-refusal-panel.js:32) take an optional test ID, and there are new unit tests. No new strings, so the POT doesn't change.UI evidence
No visible change: attributes only. The unit tests check each ID in a rendered DOM for all three surfaces. I couldn't take before/after screenshots because the local site wasn't running when this PR was raised.
How to test
godam-transcode-failure-tooltip.godam-transcode-failure-panel….Unit tests: the full JS suite passes (100 suites, 1390 tests). ESLint and PHPCS are clean.
Risk
risk: lowbecause it only addsdata-test-idattributes; no logic changes.